Add Inject interface chain elem #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Semenov <sergey.semenov@xored.com>
Signed-off-by: Sergey Semenov <sergey.semenov@xored.com>
lvfxx
force-pushed
the
inject-interface-chain-elem
branch
from
ed3bfbe to
7803857
Compare
Signed-off-by: Sergey Semenov <sergey.semenov@xored.com>
lvfxx
force-pushed
the
inject-interface-chain-elem
branch
from
9946957 to
2069e16
Compare
Signed-off-by: Sergey Semenov <sergey.semenov@xored.com>
lvfxx
force-pushed
the
inject-interface-chain-elem
branch
from
0b7b881 to
ada7cab
Compare
haiodo
reviewed
Jul 22, 2020
| } | ||
| log.Entry(ctx).Infof("Moved network interface %s into the Client's namespace for connection %s", ifaceName, request.GetConnection().GetId()) | ||
|
|
||
| return next.Server(ctx).Request(ctx, request) |
There was a problem hiding this comment.
We should check if next return Error, we need to move interface back.
haiodo
reviewed
Jul 22, 2020
| } | ||
|
|
||
| // NewServer - returns a new networkservice.NetworkServiceServer that moves given network interface into the Client's | ||
| // pod network namespace on Request and back to Forwarder's network namespace on Close |
Signed-off-by: Sergey Semenov <sergey.semenov@xored.com>
haiodo
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add injectServer that moves network interface to and from a Client's pod network namespace. This server was initially written for sdk-sriov and now is moved in this repo for reuse