add kernel interface manipulation utilities #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add idempotent wrapper for netlink library * add utilities for finding netlink interfaces representing host devices, e.g. SR-IOV virtual functions Signed-off-by: Przemyslaw Lal <przemyslawx.lal@intel.com>
przemeklal
force-pushed
the
add-netlink-utils
branch
from
14ff7c5 to
25f305e
Compare
rdimitrov
approved these changes
Feb 10, 2020
edwarnicke
reviewed
Feb 10, 2020
| MoveToNetns(target netns.NsHandle) error | ||
| SetAdminState(state State) error | ||
| SetName(name string) error | ||
| } |
There was a problem hiding this comment.
I love that this makes things mockable :)
|
@rktidwell Does this look good to you? |
rktidwell
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devices, e.g. SR-IOV virtual functions
Signed-off-by: Przemyslaw Lal przemyslawx.lal@intel.com