[qfix] Fix createpod name generation #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Bolodya1997
approved these changes
May 24, 2021
denis-tingaikin
approved these changes
May 24, 2021
nsmbot
pushed a commit
that referenced
this pull request
Jun 27, 2023
…k@main PR link: networkservicemesh/sdk#1477 Commit: 6f90924 Author: Network Service Mesh Bot Date: 2023-06-27 15:50:46 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1477) PR link: networkservicemesh/api#160 Commit: 9785eac Author: Danil Uzlov Date: 2023-06-27 21:36:11 +0700 Message: - Add RESELECT_REQUESTED connection state (#160) * add reselect connection state * fix ci --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently by default
createpodelement uses name<podName>-nodeName=<nodeName>for created pods, and such names are not valid pod names in kubernetes. Names must only consist of lower case alphanumeric characters,-or..This PR fixes default name generation function.
How Has This Been Tested?
Types of changes