Use regex for all containers in pod cgroup #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.golangci.yml
Outdated
| @@ -169,3 +169,13 @@ issues: | |||
| exclude-use-default: false | |||
| max-issues-per-linter: 0 | |||
| max-same-issues: 0 | |||
| exclude-rules: | |||
There was a problem hiding this comment.
Could you add .golangci.yml into .templateingore?
Bolodya1997
force-pushed
the
pod-cgroup
branch
from
d00f555 to
d79c5eb
Compare
|
|
||
| func podCgroupDirPath(containerCgroupDirPath string) string { | ||
| split := strings.Split(containerCgroupDirPath, string(filepath.Separator)) | ||
| split[len(split)-1] = "*" // any container match |
There was a problem hiding this comment.
Why do we need to replace here?
There was a problem hiding this comment.
For kubernetes we have such cgroup path for the container:
.../pod-id/container-id
so if we want select all containers in pod, it should be:
.../pod-id/*
main.go
Outdated
| func podCgroupDirPath(containerCgroupDirPath string) string { | ||
| split := strings.Split(containerCgroupDirPath, string(filepath.Separator)) | ||
| split[len(split)-1] = "*" // any container match | ||
| return strings.Join(split, string(filepath.Separator)) |
There was a problem hiding this comment.
Suggested change
| return strings.Join(split, string(filepath.Separator)) | |
| return path.Join(split...) |
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
pod-cgroup
branch
from
d79c5eb to
7a25b2a
Compare
denis-tingaikin
approved these changes
Dec 9, 2020
nsmbot
pushed a commit
that referenced
this pull request
Jun 2, 2021
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/35cd28e6f6ab4047b0ad0ca35035403e1e8d400d commit 35cd28e6f6ab4047b0ad0ca35035403e1e8d400d Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Wed Jun 2 22:05:05 2021 +0700 fix: Make consistent sha from 'docker-push-ghcr' and 'update deployments-k8s repository (#75) Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If we pass only sidecar container cgroup, forwarder can't add permissions to the client container.
Solution
Pass regex describing all containers in pod.