refactor: Simplify cmd-nsc #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
simlify-client
branch
from
45420ac to
91c5757
Compare
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
simlify-client
branch
from
ea93a4e to
551d4a8
Compare
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
haiodo
reviewed
Feb 24, 2021
main.go
Outdated
| client.WithAuthorizeClient(authorize.NewClient()), | ||
| client.WithAdditionalFunctionality( | ||
| mechanisms.NewClient(map[string]networkservice.NetworkServiceClient{ | ||
| vfiomech.MECHANISM: chain.NewNetworkServiceClient(vfio.NewClient(), sriovtoken.NewClient()), |
There was a problem hiding this comment.
It seems sriovtoken.NewClient() it is required for kernelmech.MECHANISM scenario as well.
haiodo
approved these changes
Feb 24, 2021
nsmbot
pushed a commit
that referenced
this pull request
Jan 18, 2024
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/8b3ce39b8f3cbfec1f1e1ce445893118f514d0ee commit 8b3ce39b8f3cbfec1f1e1ce445893118f514d0ee Author: Nikita Skrynnik <93182827+NikitaSkrynnik@users.noreply.github.com> Date: Thu Jan 18 19:54:16 2024 +1100 Update Spire and Delve in Dockerfile (#126) Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Motivation
cmd-nsc should be clear for folks.
Depends on networkservicemesh/sdk#720