Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual update #444

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Manual update #444

merged 1 commit into from
Dec 16, 2021

Conversation

Mixaster995
Copy link
Contributor

Signed-off-by: Mikhail Avramenko avramenkomihail15@gmail.com

Issue

closes #433

@Mixaster995
manual update
fdfc586 
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
denis-tingaikin
denis-tingaikin requested changes Dec 16, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update is not correct.

Please fix the problem from update with

Error: ./main.go:83:41: too many arguments in call to logruslogger.New
	have (context.Context, map[string]interface {})
	want (context.Context)

@denis-tingaikin
Copy link
Member

OK, I see the problem is related to Ed's version downgrade.

So merging.

@denis-tingaikin denis-tingaikin merged commit abae4fa into networkservicemesh:main Dec 16, 2021
@Mixaster995 Mixaster995 deleted the qfix/manual-update branch December 16, 2021 11:00
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Dec 16, 2021
Update go.mod and go.sum to latest version from networkservicemesh/cm…
f01e9ab 
…d-forwarder-vpp@main

PR link: networkservicemesh/cmd-forwarder-vpp#444

Commit: abae4fa
Author: Авраменко Михаил
Date: 2021-12-16 18:00:14 +0700
Message:
  - manual update (#444)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Dec 16, 2021
Merged
@Mixaster995 Mixaster995 restored the qfix/manual-update branch December 17, 2021 03:53
nsmbot pushed a commit that referenced this pull request Jun 29, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
57d12dd 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#444

Commit: 2066af3
Author: Artem Glazychev
Date: 2023-06-29 20:13:03 +0700
Message:
  - Merge pull request #444 from networkservicemesh/update-go-1-20
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
LionelJouin pushed a commit to Nordix/nsm-cmd-forwarder-vpp that referenced this pull request Nov 16, 2023
@denis-tingaikin
Merge pull request networkservicemesh#444 from networkservicemesh/upd…
d1a3845 
…ate/networkservicemesh/sdk

Update from update/networkservicemesh/sdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mixaster995 @denis-tingaikin