Properly handle disconnects when watching config map updates #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
denis-tingaikin
requested review from
denis-tingaikin,
edwarnicke,
glazychev-art,
NikitaSkrynnik and
ThetaDR
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
denis-tingaikin
approved these changes
Jan 24, 2023
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jan 24, 2023
…d-exclude-prefixes-k8s@main PR link: networkservicemesh/cmd-exclude-prefixes-k8s#186 Commit: 8972f5e Author: Denis Tingaikin Date: 2023-01-24 11:13:30 +0300 Message: - Merge pull request #186 from d-uzlov/183/disconnect-healing Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when an error happens during listening for config map updates, the app stops listening.
This PR fixes that by reconnecting after an error.
Issue link
#183
How Has This Been Tested?
Types of changes