Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2074 Update ModuleRegistry to remove isMaskConfigProperties #2075

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fixes #2074 Update ModuleRegistry to remove isMaskConfigProperties #2075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions utility/src/main/java/com/networknt/utility/ModuleRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ public class ModuleRegistry {
public static void registerModule(String configName, String moduleClass, Map<String, Object> config, List<String> masks) {
// use module name as key for the config map will make api-certification parses this object easily.
if(config != null) {
if(ServerConfig.getInstance().isMaskConfigProperties() && masks != null && !masks.isEmpty()) {
// TODO remove the mask config properties as the config contains sensitive information. We need to build another config
// loader to load the config without decryption for the registry.
//if(ServerConfig.getInstance().isMaskConfigProperties() && masks != null && !masks.isEmpty()) {
if(masks != null && !masks.isEmpty()) {
for (String mask : masks) {
maskNode(config, mask);
}
Expand Down Expand Up @@ -71,7 +74,9 @@ public static Map<String, Object> getModuleRegistry() {
public static void registerPlugin(String pluginName, String pluginVersion, String configName, String pluginClass, Map<String, Object> config, List<String> masks) {
// use plugin name as key for the config map will make api-certification parses this object easily.
if(config != null) {
if(ServerConfig.getInstance().isMaskConfigProperties() && masks != null && !masks.isEmpty()) {
// TODO update along with the registerModule.
// if(ServerConfig.getInstance().isMaskConfigProperties() && masks != null && !masks.isEmpty()) {
if(masks != null && !masks.isEmpty()) {
for (String mask : masks) {
maskNode(config, mask);
}
Expand Down