Fixes #2012 order dependent tests in CorrelationTest
#2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed order dependent tests in CorrelationHandlerTest by reloading CorrelationConfig
SaaiVenkat
changed the title
CorrelationTestCorrelationTest
stevehu
approved these changes
Nov 27, 2023
|
@SaaiVenkat It makes sense. Thanks a lot for your help. |
younggwon1
pushed a commit
to younggwon1/light-4j
that referenced
this pull request
Feb 10, 2024
Fixed order dependent tests in CorrelationHandlerTest by reloading CorrelationConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
com.networknt.correlation.CorrelationHandlerTest, the unit testtestGetWithoutTidNoAutogen()can triggerjava.lang.AssertionErrorwhen being run before the unit testtestGetWithoutTid()in the same class because it pollutes state shared among tests.Fixes #2012
Solution
CorrelationHandler.configto default value after the testtestGetWithoutTidNoAutogenis run usingCorrelationHandler.config.setAutogenCorrelationID(true);