Fix NPE when walking a missing node that will have missing properties #1152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1151
Fixes the NPE by having
TypeFactory.getValueNodeType((JsonNode node, SchemaValidatorsConfig config)
handle the case where anull
was passed in as the node.I had considered if it should be ensured that the node inputs should always be non null and always replace
null
byMissingNode
instead. For instance havingPropertiesValidator
set the input asMissingNode
instead ofnull
. But sinceJsonNode.get(String fieldName)
returnsnull
for missing nodes I wasn't sure it would be appropriate.