Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proxy as suggested issuer #533

Merged
merged 32 commits into from
Dec 21, 2021

Conversation

lem-onade
Copy link
Collaborator

@lem-onade lem-onade commented Dec 8, 2021

Merge #538 first!

The authentication in the manage app should work exactly as before.

@lem-onade lem-onade added the enhancement New feature or request label Dec 9, 2021
@lem-onade lem-onade self-assigned this Dec 9, 2021
@lem-onade lem-onade requested a review from johannadm December 9, 2021 15:45
Copy link
Member

@ddeboer ddeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need some changes in .github/workflows/ci.yml to build the proxy app Docker image so I can run that in our infrastructure.

Never mind, my comment belongs in #527.

@lem-onade lem-onade mentioned this pull request Dec 14, 2021
@lem-onade lem-onade marked this pull request as ready for review December 15, 2021 16:31
johannadm
johannadm previously approved these changes Dec 17, 2021
Copy link
Collaborator

@johannadm johannadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in chrome, firefox, safari

@johannadm johannadm self-requested a review December 20, 2021 16:28
johannadm
johannadm previously approved these changes Dec 20, 2021
…rs into chore/implement-shared-authenticate-component
@lem-onade lem-onade merged commit fc7a4e7 into develop Dec 21, 2021
@lem-onade lem-onade deleted the chore/implement-shared-authenticate-component branch December 21, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants