fix: dont allow adding of an empty local term #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs into fix/dont-save-local-term-when-empty
lem-onade
requested changes
Nov 9, 2021
Nevermind, if we add an icon like this it should probably always be present and not take the place of the plus icon or be right next to it. I'm fine with just having an empty space with the same width as the plus icon |
…bs into fix/dont-save-local-term-when-empty
lem-onade
approved these changes
Nov 16, 2021
lem-onade
added a commit
that referenced
this pull request
Nov 16, 2021
* chore: update translator (#475) * chore: update translator * Docs: usermanual updated (#384) * docs: user manual objecten added * docs: user manual objects * docs: user manual termennetwerk * docs: updated user manual and install command * Update docs/modules/manual/pages/objecten.adoc Co-authored-by: Stijn Taelemans <stijn@digita.ai> * Update docs/modules/manual/pages/termennetwerk.adoc Co-authored-by: Stijn Taelemans <stijn@digita.ai> * Update docs/modules/manual/pages/objecten.adoc Co-authored-by: Stijn Taelemans <stijn@digita.ai> * docs: edtf extra info * docs: user manual updated * Update docs/modules/manual/pages/termennetwerk.adoc Co-authored-by: Stijn Taelemans <stijn@digita.ai> * Update docs/modules/manual/pages/presentatiemodule.adoc Co-authored-by: Stijn Taelemans <stijn@digita.ai> * Update docs/modules/manual/pages/presentatiemodule.adoc Co-authored-by: Stijn Taelemans <stijn@digita.ai> * Apply suggestions from code review Co-authored-by: Stijn Taelemans <stijn@digita.ai> * docs: changes based on review * docs: add own term * docs: add beheerder docs * chore: typo * docs: apply changes from review * docs: nav adjusted Co-authored-by: Stijn Taelemans <stijn@digita.ai> * docs: add link to beheerders.adoc * docs: update requirements to second phase (#494) Co-authored-by: Wouter Janssens <wouter@digita.ai> * build: update token for digita packages (#500) * fix: fixed width of field titles in presentation package (#499) Co-authored-by: Stijn Taelemans <stijn@digita.ai> * fix: fixed wait for translator before rendering (#501) * fix: term uris are not clickable (#480) * fix: clicking URLs in term search now opens page in new tab * chore: added norefferer to prevent tabnabbing * test: updated testes * fix: object page no longer crashes when saving local terms (#502) * fix: dont error on local term use * fix: save local terms properly * chore: lowered test coverage * fix: image popup scaling in firefox and safari (#503) * fix: scroll to edited term field (#504) * fix: scroll to edited term field * chore: remove unnecessary `?` * chore: release v0.10.2 * docs: infrastructure added to scope (#506) * fix: add loading/progress bar when searching objects (#505) * chore: deploy pods * chore: release v0.10.3 * chore: update package-lock * chore: release v0.10.4 * chore: update dockerfile and config for pods * chore: release v0.10.5 * chore: release v0.10.6 * chore: update deployment for pods * fix: remove alerts on navigation (#508) * chore: update start script for pods * chore: add setup for pods * feat: download collection object .ttl files (#509) * fix: improve object search algorithm (#510) * feat: improve search mechanism * feat: download collection object .ttl files (#509) * feat: download rdf ttl file * fix: changed default fetch for solid fetch * fix: adapted search algorithm to achieve desired outcome * fix: dont allow adding of an empty local term (#512) * fix: dont allow adding of an empty local term * fix: dont move input field when local term is empty * feat: always show active notifications on screen (#513) * fix: clicking dropdown arrow should open and close menu (#516) * feat: dropdown arrow opens and closes menu * feat: add cursor pointer to the dropdown menu * feat: add cursor pointer to the dropdown menu * fix: weird linting error * fix: remove unnecesary :hover * fix: styelint error * feat: added button to open presentation view from manage view (#507) * feat: added button to open presentation view from manage view * feat: added share button to object page Co-authored-by: Stijn Taelemans <stijn@digita.ai> * chore: release v0.11.0 Co-authored-by: Johanna De Maeyer <80322390+johannadm@users.noreply.github.com> Co-authored-by: Wouter Janssens <wouter@digita.ai> Co-authored-by: Arthur Joppart <38424924+BelgianNoise@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.