Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling fixes #212

Merged
merged 7 commits into from
May 20, 2021
Merged

Styling fixes #212

merged 7 commits into from
May 20, 2021

Conversation

lem-onade
Copy link
Collaborator

@lem-onade lem-onade commented May 17, 2021

  • add ellipsis to list items
  • add ellipsis to collection title and description when not editing
  • fix scrolling in sidebar
  • fix scrolling in page content

@BelgianNoise BelgianNoise linked an issue May 17, 2021 that may be closed by this pull request
BelgianNoise
BelgianNoise previously approved these changes May 17, 2021
@lem-onade lem-onade enabled auto-merge (squash) May 18, 2021 07:44
@lem-onade lem-onade marked this pull request as draft May 18, 2021 07:45
auto-merge was automatically disabled May 18, 2021 07:45

Pull request was converted to draft

@lem-onade lem-onade linked an issue May 18, 2021 that may be closed by this pull request
@lem-onade
Copy link
Collaborator Author

Scrollbars in sidebar and page content

image

@lem-onade lem-onade requested a review from BelgianNoise May 18, 2021 12:51
@lem-onade lem-onade marked this pull request as ready for review May 18, 2021 12:51
@lem-onade lem-onade enabled auto-merge (squash) May 18, 2021 12:52
@lem-onade lem-onade requested a review from johannadm May 18, 2021 12:58
@johannadm johannadm closed this May 19, 2021
auto-merge was automatically disabled May 19, 2021 10:17

Pull request was closed

@lem-onade lem-onade reopened this May 19, 2021
Copy link
Collaborator

@johannadm johannadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"add ellipsis to collection title and description when not editing" not fixed

@lem-onade lem-onade requested a review from johannadm May 20, 2021 08:12
Copy link
Collaborator

@johannadm johannadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@lem-onade lem-onade merged commit 58746ae into develop May 20, 2021
@lem-onade lem-onade deleted the fix/styling-fixes branch May 20, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants