Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favicon #182

Merged
merged 8 commits into from
May 18, 2021
Merged

Add favicon #182

merged 8 commits into from
May 18, 2021

Conversation

lem-onade
Copy link
Collaborator

@lem-onade lem-onade commented May 10, 2021 •
edited
Loading

Used favicons from nde's website

@lem-onade lem-onade linked an issue May 10, 2021 that may be closed by this pull request
Configure favicon #177
Closed
@wouteraj wouteraj self-requested a review May 10, 2021 12:14
@lem-onade lem-onade enabled auto-merge (squash) May 10, 2021 16:44
wouteraj
wouteraj requested changes May 11, 2021
View reviewed changes
Copy link
Collaborator

@wouteraj wouteraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to use a local version of the favicon, instead of referencing one we have no control over. If I understand correctly, our bundler will automatically include any assets referenced in index.html, so should be easy.

@lem-onade lem-onade requested a review from wouteraj May 17, 2021 16:24
@wouteraj wouteraj disabled auto-merge May 18, 2021 04:24
@wouteraj wouteraj merged commit fe0d06d into develop May 18, 2021
@wouteraj wouteraj deleted the feat/add-favicon branch May 18, 2021 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BelgianNoise BelgianNoise BelgianNoise approved these changes

@arnevandoorslaer arnevandoorslaer Awaiting requested review from arnevandoorslaer

@wouteraj wouteraj Awaiting requested review from wouteraj

Assignees

@lem-onade lem-onade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure favicon
3 participants
@lem-onade @wouteraj @BelgianNoise