fix: Translator should return key when no translation found (#79)

* fix: translator returns null when no translation found

* test: updated tests

packages/nde-erfgoed-components/lib/alerts/alert.component.spec.ts

@@ -72,7 +72,7 @@ describe('AlertComponent', () => {
 
     const message = window.document.body.getElementsByTagName('nde-alert')[0].shadowRoot.querySelector('.message').innerHTML.replace(/<!---->/g, '');
 
-    expect(message.trim()).toBe('');
+    expect(message.trim()).toBe(component.alert.message);
 
   });
 

packages/nde-erfgoed-core/lib/i8n/memory-translator.spec.ts

@@ -35,7 +35,7 @@ describe('MemoryTranslator', () => {
 
   describe('translate', () => {
 
-    it('Should translate an existing key in an existing locale.', () => {
+    it('Should return an existing key in an existing locale.', () => {
 
       const value = service.translate('foo', 'en-GB');
 
@@ -51,19 +51,19 @@ describe('MemoryTranslator', () => {
 
     });
 
-    it('Should translate return null with an existing key in an non-existing locale.', () => {
+    it('Should return the input key with an existing key in an non-existing locale.', () => {
 
       const value = service.translate('foo.bar', 'nl-NL');
 
-      expect(value).toBeFalsy();
+      expect(value).toEqual('foo.bar');
 
     });
 
-    it('Should translate return null with an non-existing key in an existing locale.', () => {
+    it('Should return the input key with an non-existing key in an existing locale.', () => {
 
       const value = service.translate('lorem', 'nl-NL');
 
-      expect(value).toBeFalsy();
+      expect(value).toEqual('lorem');
 
     });
 

packages/nde-erfgoed-core/lib/i8n/memory-translator.ts

@@ -46,7 +46,8 @@ export class MemoryTranslator {
       (translation) => translation.locale === usedLocale && translation.key === key
     );
 
-    return foundTranslation ? foundTranslation.value : null;
+    // return key when no translation was found
+    return foundTranslation?.value || key;
 
   }