Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroll to edited term field #504

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Conversation

BelgianNoise
Copy link
Collaborator

No description provided.

@BelgianNoise BelgianNoise self-assigned this Oct 28, 2021
@BelgianNoise BelgianNoise linked an issue Oct 28, 2021 that may be closed by this pull request
@BelgianNoise BelgianNoise marked this pull request as ready for review October 28, 2021 15:01
johannadm
johannadm previously approved these changes Oct 28, 2021
Copy link
Collaborator

@johannadm johannadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well in chrome, firefox and safari!

@lem-onade lem-onade enabled auto-merge (squash) October 28, 2021 15:26
@lem-onade lem-onade disabled auto-merge October 28, 2021 15:28
@lem-onade lem-onade merged commit ccae1ee into develop Oct 28, 2021
@lem-onade lem-onade deleted the fix/scroll-to-edited-term-field branch October 28, 2021 15:36
lem-onade added a commit that referenced this pull request Nov 16, 2021
* chore: update translator (#475)

* chore: update translator

* Docs: usermanual updated (#384)

* docs: user manual objecten added

* docs: user manual objects

* docs: user manual termennetwerk

* docs: updated user manual and install command

* Update docs/modules/manual/pages/objecten.adoc

Co-authored-by: Stijn Taelemans <stijn@digita.ai>

* Update docs/modules/manual/pages/termennetwerk.adoc

Co-authored-by: Stijn Taelemans <stijn@digita.ai>

* Update docs/modules/manual/pages/objecten.adoc

Co-authored-by: Stijn Taelemans <stijn@digita.ai>

* docs: edtf extra info

* docs: user manual updated

* Update docs/modules/manual/pages/termennetwerk.adoc

Co-authored-by: Stijn Taelemans <stijn@digita.ai>

* Update docs/modules/manual/pages/presentatiemodule.adoc

Co-authored-by: Stijn Taelemans <stijn@digita.ai>

* Update docs/modules/manual/pages/presentatiemodule.adoc

Co-authored-by: Stijn Taelemans <stijn@digita.ai>

* Apply suggestions from code review

Co-authored-by: Stijn Taelemans <stijn@digita.ai>

* docs: changes based on review

* docs: add own term

* docs: add beheerder docs

* chore: typo

* docs: apply changes from review

* docs: nav adjusted

Co-authored-by: Stijn Taelemans <stijn@digita.ai>

* docs: add link to beheerders.adoc

* docs: update requirements to second phase (#494)

Co-authored-by: Wouter Janssens <wouter@digita.ai>

* build: update token for digita packages (#500)

* fix: fixed width of field titles in presentation package (#499)

Co-authored-by: Stijn Taelemans <stijn@digita.ai>

* fix: fixed wait for translator before rendering (#501)

* fix: term uris are not clickable (#480)

* fix: clicking URLs in term search now opens page in new tab

* chore: added norefferer to prevent tabnabbing

* test: updated testes

* fix: object page no longer crashes when saving local terms (#502)

* fix: dont error on local term use

* fix: save local terms properly

* chore: lowered test coverage

* fix: image popup scaling in firefox and safari (#503)

* fix: scroll to edited term field (#504)

* fix: scroll to edited term field

* chore: remove unnecessary `?`

* chore: release v0.10.2

* docs: infrastructure added to scope (#506)

* fix: add loading/progress bar when searching objects (#505)

* chore: deploy pods

* chore: release v0.10.3

* chore: update package-lock

* chore: release v0.10.4

* chore: update dockerfile and config for pods

* chore: release v0.10.5

* chore: release v0.10.6

* chore: update deployment for pods

* fix: remove alerts on navigation (#508)

* chore: update start script for pods

* chore: add setup for pods

* feat: download collection object .ttl files (#509)

* fix: improve object search algorithm (#510)

* feat: improve search mechanism

* feat: download collection object .ttl files (#509)

* feat: download rdf ttl file

* fix: changed default fetch for solid fetch

* fix: adapted search algorithm to achieve desired outcome

* fix: dont allow adding of an empty local term (#512)

* fix: dont allow adding of an empty local term

* fix: dont move input field when local term is empty

* feat: always show active notifications on screen (#513)

* fix: clicking dropdown arrow should open and close menu (#516)

* feat: dropdown arrow opens and closes menu

* feat: add cursor pointer to the dropdown menu

* feat: add cursor pointer to the dropdown menu

* fix: weird linting error

* fix: remove unnecesary :hover

* fix: styelint error

* feat: added button to open presentation view from manage view (#507)

* feat: added button to open presentation view from manage view

* feat: added share button to object page

Co-authored-by: Stijn Taelemans <stijn@digita.ai>

* chore: release v0.11.0

Co-authored-by: Johanna De Maeyer <80322390+johannadm@users.noreply.github.com>
Co-authored-by: Wouter Janssens <wouter@digita.ai>
Co-authored-by: Arthur Joppart <38424924+BelgianNoise@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put focus on the field to which I've added a term
3 participants