Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidMidiTest moved to AndroidMidi module, project restructured to new Android conventions #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tkirshboim
Copy link
Contributor

I've done some more restructuring to conform to the new Android project structure conventions and also allow building all of the projects contained in this repository with the new gradle build system. These changes include:

  • Changed the folder structure of the AndroidMidi project to the current convention - The main reason for doing this was to allow running the java junit tests from 'AndroidMidiTest' using the Android gradle plugin.
  • Moved the 'AndroidMidiTest' java junit test module to the 'AndroidMidi' module.
  • Added all the modules contained in this repository to the root gradle project. Running ./gradlew assembleRelease will now build all of them, not only AndroidMidi.

It is now possible to run the tests by running ./gradlew test from the command line or in Android Studio (For that note that you should click the 'Build Variants' tab and there select 'Unit Tests' as the test artifact).

While running the tests, some tests in 'SystemMessageEncoderTest.java' failed. I'm not familiar with the code itself, so I'm not sure if this is a 'real' failure or perhaps a misconfiguration of the mock instance. I also don't know when was the last time that these tests passed, this is the first time today that I tried to run them. See the attached result:
TestResults.pdf

… AndroidMidi

and changed AndroidMidi to use the new Android project structure convention (to allow easier java unit testing integration)
@tkirshboim
Copy link
Contributor Author

removed 'MidiPlayer/src/META-INF/MANIFEST.MF' file that broke the debug build of the MidiPlayer app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant