Debugger: shows error message in console #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Output looks like this: Build failure is unrelated to the PR, symplify/ecs seems to be broken. |
|
I wouldn't put a sentence |
|
I usually enable debug mode, to see stack trace, etc. Writing into log may fail. What about |
|
If it's been logged, there's no need to do anything. |
Good point, changed. With log Without log |
|
Great! |
dg
changed the title
Ciki
reviewed
Jun 7, 2021
| @@ -319,8 +319,12 @@ public static function exceptionHandler(\Throwable $exception): void | |||
| require self::$errorTemplate ?: __DIR__ . '/assets/error.500.phtml'; | |||
| })(empty($e)); | |||
| } elseif (PHP_SAPI === 'cli') { | |||
| @fwrite(STDERR, 'ERROR: application encountered an error and can not continue. ' | |||
| . (isset($e) ? "Unable to log error.\n" : "Error was logged.\n")); // @ triggers E_NOTICE when strerr is closed since PHP 7.4 | |||
| // @ triggers E_NOTICE when strerr is closed since PHP 7.4 | |||
There was a problem hiding this comment.
@dg there's a typo strerr should be stderr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just don't think there is a reason to not show error message in console. But I may be wrong, let me know if I missed something.