Introduce and use decorators for graph sanitizers #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit (in addition to a few cosmetic changes like cleaning up typos I encountered) introduces two decorators, `@unweighted` and `@undirected`, that apply the `ensure_unweighted()` and `ensure_undirected()` functions to each positional argument to a function that is subclassed from `nx.Graph()`.
leotrs
reviewed
Feb 17, 2020
We have tests for handling weighted and directed input. Given that, the fact that the existing tests passed suggest that the decorators work, at least on the graph distance side. The decorators are also used in dynamics, where test coverage is considerably worse. Not systematic, but if you comment out
The decorators are calling the |
leotrs
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (in addition to a few cosmetic changes like cleaning up typos I
encountered) introduces two decorators,
@unweightedand@undirected, thatapply the
ensure_unweighted()andensure_undirected()functions to eachpositional argument to a function that is subclassed from
nx.Graph().