Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1340: Add operator to "Observability" category in OperatorHub #440

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

stleerh
Copy link
Contributor

@stleerh stleerh commented Sep 29, 2023

The name says it all. This adds the "Observability" category if it doesn't exist and adds Network Observability to this category.

observability_category

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 29, 2023

@stleerh: This pull request references NETOBSERV-1340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

The name says it all. This adds the "Observability" category if it doesn't exist and adds Network Observability to this category.

observability_category

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (530ba8c) 55.69% compared to head (7afef13) 56.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   55.69%   56.20%   +0.51%     
==========================================
  Files          47       47              
  Lines        6063     6063              
==========================================
+ Hits         3377     3408      +31     
+ Misses       2447     2420      -27     
+ Partials      239      235       -4     
Flag Coverage Δ
unittests 56.20% <ø> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stleerh !

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 2, 2023

@stleerh: This pull request references NETOBSERV-1340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "netobserv-1.5" instead.

In response to this:

The name says it all. This adds the "Observability" category if it doesn't exist and adds Network Observability to this category.

observability_category

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak
Copy link
Member

jotak commented Oct 4, 2023

/approve
thanks!

@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 4, 2023

@stleerh: This pull request references NETOBSERV-1340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "netobserv-1.5" instead.

In response to this:

The name says it all. This adds the "Observability" category if it doesn't exist and adds Network Observability to this category.

observability_category

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak jotak merged commit d8655d0 into netobserv:main Oct 4, 2023
jotak added a commit that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants