Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1295 backport: Fix certs monitoring copy #416

Merged

Conversation

OlivierCazade
Copy link
Contributor

@OlivierCazade OlivierCazade commented Sep 14, 2023

Description

Backport of NETOBSERV-1295

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 5.40% and project coverage change: -0.30% ⚠️

Comparison is base (623a3b2) 55.70% compared to head (2f68165) 55.41%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.4     #416      +/-   ##
===============================================
- Coverage        55.70%   55.41%   -0.30%     
===============================================
  Files               46       46              
  Lines             5960     5995      +35     
===============================================
+ Hits              3320     3322       +2     
- Misses            2410     2438      +28     
- Partials           230      235       +5     
Flag Coverage Δ
unittests 55.41% <5.40%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
controllers/flowcollector_objects.go 46.91% <0.00%> (ø)
...trollers/flowlogspipeline/flp_ingest_reconciler.go 64.28% <0.00%> (-1.77%) ⬇️
...ollers/flowlogspipeline/flp_monolith_reconciler.go 64.00% <0.00%> (-1.58%) ⬇️
...rollers/flowlogspipeline/flp_transfo_reconciler.go 60.14% <0.00%> (-1.34%) ⬇️
pkg/watchers/watcher.go 64.39% <0.00%> (-7.64%) ⬇️
controllers/flowlogspipeline/flp_reconciler.go 60.56% <16.66%> (-8.93%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak
Copy link
Member

jotak commented Sep 14, 2023

/lgtm
/approve
(already verified on main)
thanks @OlivierCazade !

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5dbfa16 into netobserv:release-1.4 Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants