-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CRD documentation #304
Conversation
jotak
commented
Mar 22, 2023
- switch asciidoc gen to referencing v1beta1
- improve doc & default for ignored metrics (those changes were previously done on v1alpha1 instead of v1beta1, mistakenly)
- add enum info on disableAlerts doc (unfortunately the enum doc, while being correctly picked up for openapi, is not picked up for doc generation; so I am duplicating it)
- regenerate bundle & doc
- switch asciidoc gen to referencing v1beta1 - improve doc & default for ignored metrics (those changes were previously done on v1alpha1 instead of v1beta1, mistakenly) - add enum info on disableAlerts doc (unfortunately the enum doc, while being correctly picked up for openapi, is not picked up for doc generation; so I am duplicating it) - regenerate bundle & doc
@skrthomas here's the CRD doc update, with the re-generated asciidoc file @OlivierCazade I noticed that your PR here did not show the |
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
==========================================
- Coverage 49.66% 49.33% -0.33%
==========================================
Files 43 43
Lines 5020 5035 +15
==========================================
- Hits 2493 2484 -9
- Misses 2324 2341 +17
- Partials 203 210 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @jotak !
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |