-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow test hack #300
Conversation
@jotak do u have a logs of sample run of this new github action ? |
@msherif1234 it's not a github action - at least not yet - at the moment it's something to run manually on demand - e.g. when modifying the makefiles and wanting to make sure we don't break things. Most of the time, it's not useful to run it. Here's an output example:
And an example of failure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jotak !
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey,
There's been a bunch of regressions lately because of changes in the makefile and/or workflow, so I've written some "tests" around that. They don't yet cover everything I want (e.g. they should also cover everything that is documented in
RELEASE.md
andDEVELOPMENT.md
)