-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix operator for FLP breaking changes #289
Fix operator for FLP breaking changes #289
Conversation
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage ? 47.42%
=======================================
Files ? 43
Lines ? 4951
Branches ? 0
=======================================
Hits ? 2348
Misses ? 2395
Partials ? 208
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The code update looks good to me. I did not run this update with the updated flp to test that it works properly. |
thanks @OlivierCazade @KalmanMeth |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related: netobserv/flowlogs-pipeline#399