-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-638: avoid infinite update-retrigger loop #193
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New image: ["quay.io/netobserv/network-observability-operator:c07ebd6"]. It will expire after two weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good catch @mariomac !
* added topk functionality to aggregate * tracked index of minimum value * added unit test for topk * performed topk on total_value instead of recent_count * implemented a heap to compute topk * added mutex to enum to avoid race condition * pre-populated the enum cache * checked actual values produced by topk in unit test * added check to optimize accesses to heap
This fixes the idempotency of the agent and FLP generation when the
env
sections were defined. It also fixes the comparison of some other resources that were unnecessarily reconciliated continuously.This PR also reverts PR #191 (NETOBSERV-694), as we realized that the error messages were mostly caused by the bug fixed in this PR.