Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go1.23, bump golangci-lint #678

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Go1.23, bump golangci-lint #678

merged 1 commit into from
Dec 20, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Dec 17, 2024

No description provided.

Copy link

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.83%. Comparing base (b6b7d14) to head (b27faf3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/handler/flows.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files         197      197           
  Lines       10154    10154           
  Branches     1192     1192           
=======================================
  Hits         5771     5771           
  Misses       4015     4015           
  Partials      368      368           
Flag Coverage Δ
uitests 59.22% <ø> (ø)
unittests 51.71% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/handler/flows.go 58.51% <0.00%> (ø)

@jotak jotak merged commit bb407dd into netobserv:main Dec 20, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant