Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Uncaught TypeError: e.currentTarget.children[0] is undefined #650

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Nov 21, 2024

I am often seeing JS errors in the console, I think happens when I'm switching between browser tabs and DOM not fully rendered yet, but not sure ...
The error is like:

Uncaught TypeError: e.currentTarget.children[0] is undefined
    D record-field.tsx:25
    onMouseOver record-field.tsx:117
    React 11
    unstable_runWithPriority scheduler.production.min.js:18
    React 9
    <anonymous> app.jsx:356
    Webpack 6
record-field.tsx:25:16
    D record-field.tsx:25
    onMouseOver record-field.tsx:117
    React 11
    unstable_runWithPriority scheduler.production.min.js:18
    React 4
    forEach self-hosted:4297
    React 5
    <anonyme> app.jsx:356
    Webpack 6

So this should fix it

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Nov 21, 2024
@jotak jotak requested a review from jpinsonneau November 21, 2024 09:30
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @jotak !

@jotak
Copy link
Member Author

jotak commented Nov 25, 2024

/approve
/retest

Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 25, 2024

@jotak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plugin-cypress 17a3498 link true /test plugin-cypress
ci/prow/images 17a3498 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jotak jotak merged commit 765ca7c into netobserv:main Nov 25, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants