-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1951: show flows with networkevents 1st for duplicate flows #649
NETOBSERV-1951: show flows with networkevents 1st for duplicate flows #649
Conversation
@msherif1234: This pull request references NETOBSERV-1951 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
d1047cc
to
b6e02ad
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=14f45f8 make set-plugin-image |
/lgtm |
cc'd @memodi will u be ok merge this or u wanted to see if it helps but it won't address all n/a ? we can still have the bug open for probably more investigations |
@msherif1234 I can take a look |
/label qe-approved |
/test plugin-cypress |
/test images |
/retest |
/test all |
@msherif1234: No presubmit jobs available for netobserv/network-observability-console-plugin@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@msherif1234: No presubmit jobs available for netobserv/network-observability-console-plugin@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@msherif1234: No presubmit jobs available for netobserv/network-observability-console-plugin@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@msherif1234: This pull request references NETOBSERV-1951 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
=======================================
Coverage 56.54% 56.54%
=======================================
Files 196 196
Lines 10063 10064 +1
Branches 1195 1195
=======================================
+ Hits 5690 5691 +1
Misses 4008 4008
Partials 365 365
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
show flows with network events set for duplicated flows
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.