-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1466 rely on duplicate different than 'true' #499
NETOBSERV-1466 rely on duplicate different than 'true' #499
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
==========================================
+ Coverage 57.38% 57.39% +0.01%
==========================================
Files 167 167
Lines 8727 8730 +3
Branches 1128 1128
==========================================
+ Hits 5008 5011 +3
Misses 3397 3397
Partials 322 322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
10f2fb6
to
aaaefe9
Compare
aaaefe9
to
ab6c749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm (not tested)
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=0ecd8a6 make set-plugin-image |
(tested and working fine) |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Description
Use
Duplicate != true
to deduplicate since we don't append false value anymoreDependencies
Allows netobserv/netobserv-ebpf-agent#276 removing
Duplicate
field when not necessaryChecklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.