Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1214 & NETOBSERV-1399 Backport #464

Merged

Conversation

jpinsonneau
Copy link
Contributor

Backport of #462

@jpinsonneau jpinsonneau requested a review from jotak January 30, 2024 14:09
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 185 lines in your changes are missing coverage. Please review.

Comparison is base (958be65) 58.23% compared to head (b7b1aa3) 57.40%.

Files Patch % Lines
pkg/handler/resources.go 4.76% 38 Missing and 2 partials ⚠️
web/src/model/topology.ts 37.50% 33 Missing and 2 partials ⚠️
pkg/loki/topology_query.go 23.52% 26 Missing ⚠️
web/src/utils/filter-options.ts 20.00% 12 Missing ⚠️
web/src/components/dropdowns/group-dropdown.tsx 52.63% 9 Missing ⚠️
web/src/components/dropdowns/scope-dropdown.tsx 10.00% 9 Missing ⚠️
...omponents/netflow-topology/2d/topology-content.tsx 0.00% 8 Missing ⚠️
web/src/utils/autocomplete-cache.ts 20.00% 8 Missing ⚠️
...nts/netflow-topology/2d/styles/styleDecorators.tsx 0.00% 6 Missing ⚠️
...src/components/netflow-topology/element-fields.tsx 0.00% 6 Missing ⚠️
... and 8 more
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5     #464      +/-   ##
===============================================
- Coverage        58.23%   57.40%   -0.84%     
===============================================
  Files              167      167              
  Lines             8467     8661     +194     
  Branches          1086     1114      +28     
===============================================
+ Hits              4931     4972      +41     
- Misses            3224     3368     +144     
- Partials           312      321       +9     
Flag Coverage Δ
uitests 58.27% <33.90%> (-0.68%) ⬇️
unittests 54.93% <14.63%> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak
Copy link
Member

jotak commented Jan 31, 2024

/lgtm
/approve
thanks!

Copy link

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a412ddc into netobserv:release-1.5 Jan 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants