-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1299 missing DNS latency in topology & NETOBSERV-1294 RTT based panels seen by default #384
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
- Coverage 57.69% 57.27% -0.42%
==========================================
Files 166 168 +2
Lines 7817 7944 +127
Branches 962 970 +8
==========================================
+ Hits 4510 4550 +40
- Misses 3030 3115 +85
- Partials 277 279 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=7ca3e15 make set-plugin-image |
/label qe-approved |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
NETOBSERV-1299 missing DNS latency in topology:
While writing the blogs article I saw that RTT was added to topology view but I never came back to DNS to make it also available.
This story enable it using the same approach as RTT: only average is available and Max / P90 / P99 will be introduced by https://issues.redhat.com/browse/NETOBSERV-1227
NETOBSERV-1294 RTT based panels seen by default:
Also took the opportunity to fix this in the same PR since the same code is affected.
It would be cool to be able to backport these to 1.4 as it's small changes: #388