-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-669: overview export PNG #322
Conversation
@Amoghrd: This pull request references NETOBSERV-669 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 55.18% 57.93% +2.74%
==========================================
Files 29 150 +121
Lines 1745 6642 +4897
Branches 0 795 +795
==========================================
+ Hits 963 3848 +2885
- Misses 694 2577 +1883
- Partials 88 217 +129
Flags with carried forward coverage won't be shown. Click here to find out more.
|
04c3c12
to
0056e65
Compare
@Amoghrd: This pull request references NETOBSERV-669 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jpinsonneau Could you please review this when you are free |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes but LGTM 🥳 thanks @Amoghrd !
Do you want to centralize the toPng
calls in a single place like utils/export.ts
?
It would avoid repeating the options, the link creation and the catch. That can be a followup if you prefer.
/hold |
5160816
to
0f46231
Compare
@jpinsonneau When implementing the |
@Amoghrd sorry about that. I didn't checked the impact of https://github.com/netobserv/network-observability-console-plugin/pull/315/files on standalone mode that actually conflicts. Also took the opportunity to refactor a bit the export function
|
/lgtm |
/unhold |
New changes are detected. LGTM label has been removed. |
New image: quay.io/netobserv/network-observability-console-plugin:97aed2d. It will expire after two weeks. |
New changes are detected. LGTM label has been removed. |
/label qe-approved |
1 similar comment
/label qe-approved |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Export overview page and each panel in overview page
Update topology export function