Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-901 Declare Observe section for project admins #300

Merged
merged 2 commits into from
May 11, 2023
Merged

NETOBSERV-901 Declare Observe section for project admins #300

merged 2 commits into from
May 11, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 3, 2023

No description provided.

@jotak jotak force-pushed the observe-project-admins branch from 7876051 to c08bf82 Compare March 3, 2023 15:56
@jotak
Copy link
Member Author

jotak commented Mar 3, 2023

/hold
We may want to hold that for a while, as multi-tenancy is not planned to be complete for 1.2

@memodi
Copy link
Contributor

memodi commented Apr 26, 2023

/unhold
/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. and removed do-not-merge/hold labels Apr 26, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:0811e0c"]. It will expire after two weeks.

@jotak jotak force-pushed the observe-project-admins branch from c08bf82 to 851ba6f Compare May 5, 2023 10:24
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 5, 2023
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023 •
edited
Loading

Codecov Report

Merging #300 (851ba6f) into main (2a47af3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   58.31%   58.31%           
=======================================
  Files         148      148           
  Lines        6592     6592           
  Branches      792      792           
=======================================
  Hits         3844     3844           
  Misses       2531     2531           
  Partials      217      217
Flag Coverage Δ
uitests 58.97% <ø> (ø)
unittests 56.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented May 5, 2023

New image: ["quay.io/netobserv/network-observability-console-plugin:ea1bb18"]. It will expire after two weeks.

OlivierCazade
OlivierCazade approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label May 5, 2023
@Amoghrd
Copy link
Contributor

Amoghrd commented May 10, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label May 10, 2023
@jotak
Copy link
Member Author

jotak commented May 11, 2023

thanks Amogh!
/approve

@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7f5929a into netobserv:main May 11, 2023
@jotak jotak deleted the observe-project-admins branch November 7, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCazade OlivierCazade OlivierCazade approved these changes

@jpinsonneau jpinsonneau Awaiting requested review from jpinsonneau

Assignees

@OlivierCazade OlivierCazade

Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jotak @memodi @Amoghrd @OlivierCazade @openshift-merge-robot