Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-871 UI: Connection tracking query option #285

Merged
merged 5 commits into from
Mar 2, 2023
Merged

NETOBSERV-871 UI: Connection tracking query option #285

merged 5 commits into from
Mar 2, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Feb 7, 2023 •
edited
Loading

This PR implements connection tracking as query option
image

It also adds 2 new related columns:

  • Connection Id
  • Type

Listing connections:
image

Listing flows:
image

It also bring a filter capability on connection id:
image

And finally the ability to switch type and filter on a particular connection id from side panel:
image

image

@jpinsonneau jpinsonneau marked this pull request as draft February 7, 2023 16:16
@jpinsonneau jpinsonneau marked this pull request as ready for review February 7, 2023 17:41
@jpinsonneau
Copy link
Contributor Author

renamed 'connection' to 'conversation' e264482 and improved tooltips / column values display

image
image

@jpinsonneau jpinsonneau mentioned this pull request Feb 8, 2023
Merged
@jpinsonneau
Copy link
Contributor Author

rename updateConnection -> heartbeat + rebased

@jpinsonneau
Copy link
Contributor Author

/hold for netobserv/network-observability-operator#252

@jpinsonneau jpinsonneau added the breaking-change This pull request has breaking changes. They should be described in PR description. label Feb 16, 2023
@jpinsonneau
Copy link
Contributor Author

/unhold sync merge netobserv/network-observability-operator#252 when both are ready
netobserv/flowlogs-pipeline#387 is optionnal to remove duplicated count in connection infos

@jpinsonneau
Copy link
Contributor Author

As suggested connection tracking is now optionnal.

@stleerh
Copy link
Contributor

stleerh commented Feb 22, 2023

Code looks good! /lgtm

@Amoghrd
Copy link
Contributor

Amoghrd commented Feb 27, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 27, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:ad90816"]. It will expire after two weeks.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 1, 2023
@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 1, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

New image: ["quay.io/netobserv/network-observability-console-plugin:2cdd415"]. It will expire after two weeks.

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 1, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Mar 1, 2023
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 2, 2023
@stleerh
Copy link
Contributor

stleerh commented Mar 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 2, 2023
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit a71223a into netobserv:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotak jotak Awaiting requested review from jotak

@OlivierCazade OlivierCazade Awaiting requested review from OlivierCazade

@ronensc ronensc Awaiting requested review from ronensc

@stleerh stleerh Awaiting requested review from stleerh

Assignees

@stleerh stleerh

Labels
approved breaking-change This pull request has breaking changes. They should be described in PR description. lgtm qe-approved QE has approved this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpinsonneau @stleerh @Amoghrd @openshift-merge-robot