-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix e2e #296
fix e2e #296
Conversation
@@ -66,8 +65,6 @@ func (bt *FlowCaptureTester) DoTest(t *testing.T) { | |||
assert.Less(t, flow["Packets"], float64(10)) | |||
assert.Less(t, time.Since(asTime(flow["TimeFlowEndMs"])), 15*time.Second) | |||
assert.Less(t, time.Since(asTime(flow["TimeFlowStartMs"])), 15*time.Second) | |||
|
|||
assert.NotEmpty(t, flow["Interface"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why yet but I'm getting <nil>
in IfDirections
and Interfaces
here 🤔
I'm investigating
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 36.74% 36.74%
=======================================
Files 42 42
Lines 3813 3813
=======================================
Hits 1401 1401
Misses 2334 2334
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
be622c2
to
3843e45
Compare
/lgtm |
@msherif1234 I have issues with IPFIX export, I wonder if it's broken 🤔 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fix e2e:
gRPC
case:IfDirections
andInterfaces
and check for arraysIPFIX
case:FlowDirection
andInterface
I would recommend to move away these tests to a new dedicated repo to avoid going back and forth updating dependencies.
These could also include console plugin cypress tests, operator deployment and CLI in future.
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.