Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ci to docker for consistency #129

Closed

Conversation

OlivierCazade
Copy link
Contributor

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oliviercazade. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak
Copy link
Member

jotak commented May 24, 2023

It conflicts with my other PR - and also needs to be done for the release workflow - so I've amended this one: #126

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #129 (fddc459) into main (3df4bfe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   41.32%   41.32%           
=======================================
  Files          31       31           
  Lines        2081     2081           
=======================================
  Hits          860      860           
  Misses       1183     1183           
  Partials       38       38           
Flag Coverage Δ
unittests 41.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants