-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new filters allowing FLP-based dedup #640
Add new filters allowing FLP-based dedup #640
Conversation
Resource footprints look good: https://docs.google.com/spreadsheets/d/1qakBaK1dk_rERO30k1cSR4W-Nn0SXW4A3lqQ1sZC4rE/edit#gid=705512397 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
- Coverage 67.41% 67.41% -0.01%
==========================================
Files 102 103 +1
Lines 7589 7641 +52
==========================================
+ Hits 5116 5151 +35
- Misses 2162 2176 +14
- Partials 311 314 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
06d3703
to
9a90e65
Compare
- New "remove_entry_all_satisfied" filter type: entry is removed only if all the conditions (represented by nested rules) are satisfied. This allows to have logical AND in filter conditions, whereas previously it was only possible to have logical OR - New "conditional_sampling" filter type: allows to have random sampling based on conditions. For example, a flow matching conditions A and B may have a sampling ratio of 1:10 whereas a flow matching condition C has 1:100 sampling and all other flows are 1:1 - Introduced a "preprocess" function on rules; currently it's only used to be able to cast the `Value interface{}` as an int (otherwise it comes as a float64); but could be also used in the future for other purpose, e.g. regex pre-compiling - Add tests
9a90e65
to
fb76a92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in terms of code
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
- Coverage 67.41% 67.41% -0.01%
==========================================
Files 102 103 +1
Lines 7589 7641 +52
==========================================
+ Hits 5116 5151 +35
- Misses 2162 2176 +14
- Partials 311 314 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This has no impact on netobserv operator currently, hence marking |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test unit |
Note this PR is based on 2 other non-merged PRs - commit ae226f9 is the significant one
Description
New "remove_entry_all_satisfied" filter type: entry is removed only if
all the conditions (represented by nested rules) are satisfied. This
allows to have logical AND in filter conditions, whereas previously it
was only possible to have logical OR
New "conditional_sampling" filter type: allows to have random sampling
based on conditions. For example, a flow matching conditions A and B
may have a sampling ratio of 1:10 whereas a flow matching condition C
has 1:100 sampling and all other flows are 1:1
Introduced a "preprocess" function on rules; currently it's only used
to be able to cast the
Value interface{}
as an int (otherwise itcomes as a float64); but could be also used in the future for other
purpose, e.g. regex pre-compiling
Add tests
Breaking change
The configuration of the
removeEntryIfXXX
rules is modified, they now all share the same key for additional configuration, which is namedremoveEntry
For example, a rule previously written as:
must be changed to:
Same applies to rules of type
remove_entry_if_doesnt_exist
,remove_entry_if_equal
andremove_entry_if_not_equal
.Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.