Conf gen updates #262
Merged
Conf gen updates #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #262 +/- ##
==========================================
+ Coverage 60.06% 60.11% +0.05%
==========================================
Files 67 69 +2
Lines 4014 4102 +88
==========================================
+ Hits 2411 2466 +55
- Misses 1451 1474 +23
- Partials 152 162 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ronensc
approved these changes
Jul 24, 2022
| @@ -54,16 +54,16 @@ func dedupeNetworkTransformRules(rules api.NetworkTransformRules) api.NetworkTra | |||
| // dedupeAggregateDefinitions is inefficient because we can't use a map to look for duplicates. | |||
| // The reason is that aggregate.AggregateDefinition is not hashable due to its AggregateBy field which is a slice. | |||
| func dedupeAggregateDefinitions(aggregateDefinitions aggregate.Definitions) aggregate.Definitions { | |||
| var dedpueSlice []api.AggregateDefinition | |||
| @@ -21,161 +21,163 @@ import ( | |||
| "fmt" | |||
| "io/ioutil" | |||
|
|
|||
| "github.com/netobserv/flowlogs-pipeline/pkg/api" | |||
| config2 "github.com/netobserv/flowlogs-pipeline/pkg/config" | |||
There was a problem hiding this comment.
I think it's better to reserve the word config for this import and rename all the other variables named "config".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.