[FIX] Fix nan_policy related bug in compare_images #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in `compare_images`. Basically, `nan` values were dropped from `srcdata` and `trgdata` regardless of whether `nan_policy` was set to `omit` or `propagate`. This is not what we want: we want to keep the `nan` values when `nan_policy` is set to `propagate`, so that the metric function can handle these values however it wants.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
[FIX] Fix nan_policy related bug in compare_images 76ef873
github-actions bot
pushed a commit
to liuzhenqi77/neuromaps
that referenced
this pull request
Jan 23, 2023
[FIX] Fix nan_policy related bug in compare_images 76ef873
github-actions bot
pushed a commit
to VinceBaz/neuromaps
that referenced
this pull request
Feb 2, 2023
[FIX] Fix nan_policy related bug in compare_images 76ef873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
compare_images.nanvalues were dropped fromsrcdataandtrgdataregardless of whethernan_policywas set toomitorpropagate. This is not what we want: we want to keep thenanvalues whennan_policyis set topropagate, so that the metric function can handle these values however it wants.This bug might be related to issue #77.