[FIX] Update install_dependencies.sh to resolve wget dns failure #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit did not work (first time it worked, but second time failed) probably because it will not catch dns resolve error. Tried this, seems to be working now (tried twice)? Doesn't seem like a long-term solution though. |
|
Sorry for the late reply, but thanks so much for looking into it! I agree that it's not a long-term solution, but it does work for now, so it's really great! I know so little about wget and internet protocols 😥 , but do you think that for the long-term, we should maybe try to figure out why there's a DNS failure/why wget can't resolve the host address? |
github-actions bot
pushed a commit
to VinceBaz/neuromaps
that referenced
this pull request
Aug 1, 2022
[FIX] Update install_dependencies.sh to resolve wget dns failure b200395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part failure due to dns resolve error. Not sure the root cause, tried 1) this and 2) adding a random sleep, both did not work. Adding retry to wget seems to work. See this link for parameter settings. Temporary patch.