[FIX] Fix bug in resample_images #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in `resample_images` that would happen when a single str or os.PathLike object specifies the path to single-hemispheric `src` or `trg` images. This bug would happen when `resample_images`would try to load the gifti file of the un-transformed map. A call to the `tranforms._check_hemi` function fixes the issue.
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2022
[FIX] Fix bug in resample_images 185444b
github-actions bot
pushed a commit
to VinceBaz/neuromaps
that referenced
this pull request
Jul 20, 2022
[FIX] Fix bug in resample_images 185444b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue#24: a bug in
resample_imagesthat would happen when a single str or os.PathLike object specifies the path to single-hemisphericsrcortrgimages. This bug would happen whenresample_imageswould try to load the gifti file of the un-transformed map. A call to thetranforms._check_hemifunction fixes the issue.