[FIX] raise error when parcellating volumetric data defined as array #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 41.15% 41.11% -0.04%
==========================================
Files 40 40
Lines 2481 2483 +2
==========================================
Hits 1021 1021
- Misses 1460 1462 +2 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
[FIX] raise error when parcellating volumetric data defined as array 5a69c29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input data to be parcellated can be array-like but the neuromaps Parcellater will assume it's surface data.
I've modified the code such that an error is thrown when MNI152 data is provided as an
np.ndarray. Volumetric data should instead be provided as a Nifti1Image. We don't convert the array to a Nifti1Image because the affine should be defined too. This PR was prompted by issue #122