Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename update for CMRglc #113

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Filename update for CMRglc #113

merged 2 commits into from
Nov 17, 2023

Conversation

eric2302
Copy link
Contributor

Changed filename of the CMRglc PET data. It used to be cmruglu and is now cmrglc according to standard convention (see e.g. Wikipedia, or papers like this one).

IMPORTANT: Before merging, we would need to update the folder and filename of CMRglc on OSF as well. It'd be awesome if someone with access to that repo could change it!

Also, changed tags in the raichle data from MRI to PET and added the tag metabolism.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abc085a) 41.15% compared to head (02fbf26) 41.15%.
Report is 5 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   41.15%   41.15%           
=======================================
  Files          40       40           
  Lines        2481     2481           
=======================================
  Hits         1021     1021           
  Misses       1460     1460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@liuzhenqi77 liuzhenqi77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justinehansen
Copy link
Contributor

I've added a new folder to the OSF with the correct filenames. I'll keep the old version up there too to make it possible to people with older versions of neuromaps to fetch the data.

Copy link
Contributor

@justinehansen justinehansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weehaw

@justinehansen justinehansen merged commit 4e2ca4c into main Nov 17, 2023
16 of 17 checks passed
@justinehansen justinehansen deleted the cmrglc_namechange branch November 17, 2023 16:14
github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants