Skip to content

Commit

Permalink
fix(snippets): ignore servers or snippets when undefined
Browse files Browse the repository at this point in the history
  • Loading branch information
javierbertoli committed Jun 14, 2021
1 parent a55f741 commit 9ba8c3c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
4 changes: 2 additions & 2 deletions nginx/servers_config.sls
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
{% set server_states = [] %}
{#- _nginx is a lightened copy of nginx map intended to passed in templates #}
{%- set _nginx = nginx.copy() %}
{%- do _nginx.pop('snippets') %}
{%- do _nginx.pop('servers') %}
{%- do _nginx.pop('snippets') if nginx.snippets is defined %}
{%- do _nginx.pop('servers') if nginx.servers is defined%}
# Simple path concatenation.
# Needs work to make this function on windows.
Expand Down
4 changes: 2 additions & 2 deletions nginx/snippets.sls
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
{#- _nginx is a lightened copy of nginx map intended to passed in templates #}
{%- set _nginx = nginx.copy() %}
{%- do _nginx.pop('snippets') %}
{%- do _nginx.pop('servers') %}
{%- do _nginx.pop('snippets') if nginx.snippets is defined %}
{%- do _nginx.pop('servers') if nginx.servers is defined %}
nginx_snippets_dir:
file.directory:
Expand Down
6 changes: 0 additions & 6 deletions test/salt/passenger/pillar/nginx.sls
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# vim: ft=yaml
---
# Simple pillar setup
# - snippet letsencrypt
# - remove 'default' site
# - create 'mysite' site

Expand All @@ -21,10 +20,6 @@ nginx:
lookup:
passenger_package: {{ passenger_pkg }}

snippets:
letsencrypt.conf:
- location ^~ /.well-known/acme-challenge/:
- proxy_pass: http://localhost:9999
server:
config:
# This is required to get the passenger module loaded
Expand Down Expand Up @@ -63,4 +58,3 @@ nginx:
- index: 'index.html index.htm'
- location ~ .htm:
- try_files: '$uri $uri/ =404'
- include: '/etc/nginx/snippets/letsencrypt.conf'

0 comments on commit 9ba8c3c

Please sign in to comment.