Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document OPERATOR_TOKEN as required #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adam-beck
Copy link

- Summary

The documentation does not signal that the OPERATOR_TOKEN is required but the code indeed requires this.

- Test plan

Not Applicable

- Description for the changelog

Update Documentation regarding OPERATOR_TOKEN

- A picture of a cute animal (not mandatory but encouraged)

@adam-beck adam-beck requested review from a team as code owners May 18, 2021 04:32
@adam-beck
Copy link
Author

adam-beck commented May 18, 2021

Unless I'm missing something (and I'm very new to Golang), it appears this line makes the OPERATOR_TOKEN required regardless if in multi-instance mode or not. I didn't see any way GlobalConfiguration wouldn't be used.

@kangmingtay
Copy link

Is there a reason why the OPERATOR_TOKEN is used to sign the token here instead of JWT_SECRET? It seems like regardless of whether gotrue is set to multi-instance mode or not, we use the operator token to sign the token when authenticating via external providers.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants