fix: front slashes only get escaped now if they aren't already #376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for sending this pull request! 🎉
Please make sure the title is clear and descriptive.
If you are fixing a typo or documentation, please skip these instructions.
Otherwise please fill in the sections below.
Which problem is this pull request solving?
Currently Next.js middleware breaks because the edge bundler modifies the regular expression matchers for URLs that Next.js generates.
List other issues or pull requests related to this problem
fixes #375
fixes https://github.com/netlify/pod-ecosystem-frameworks/issues/414
relates to opennextjs/opennextjs-netlify#1919
Describe the solution you've chosen
I've modified the regex to do a negative lookbehind to ensure we don't escape a front slash if it's already escaped.
Describe alternatives you've considered
N/A but as I mentioned in the issue, do we want the edge bundler modifying regex patterns?
Checklist
Please add a
x
inside each checkbox:A picture of a cute animal (not mandatory but encouraged)