fix: wait for chokidar ready event before listening to function builder src directory #974
+27
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR @erezrokah |
|
My pleasure 😄 |
This was referenced Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes #904
- Test plan
You can follow my comment here to reproduce
- Description for the changelog
chokidar sends an initial
addevent for each existing file in the watched directory.In the case of the bug, that event was fired for each file under
functions/node_modulesspawning multiple build commands.You can ignore those initial events by waiting for the
readyevent or passingignoreInitial:https://github.com/paulmillr/chokidar#path-filtering
Also debounced the build command to make sure only one instance of it executes at a single point in time.
- A picture of a cute animal (not mandatory but encouraged)
🐈