Improve how the project root is resolved

[ehmicky]

As described in #859, this improves how the project root is resolved, by moving the findRoot logic to @netlify/config instead.

Note: this PR is a WIP since it requires netlify/build#1579 and netlify/build#1580 to be merged first. This is why the tests are currently failing.

[ehmicky]

I have updated this PR based on #859 (comment).

[ehmicky]

There seem to be still be some issues, debugging right now.

[ehmicky]

Problems fixed! Ready for testing.

[erezrokah]

Tested and the fix works.
Also - the code looks much simpler now, thanks @ehmicky!

[JamesMcMahon]

Does this change result in breaking existing configuration?

My configuration, which was:

[build]
  publish = "build"

Broke post netlify cli upgrade, (went from 2.51.0 to 2.58.0).

The behavior I see is that the CLI is no longer is checking for build relative to where I am running the deploy command. It now expects build to be off of the repo root. To be more specific, I cd in my frontend directory and run npm build and then run the deploy command. Worked in 2.51.0, but in 2.58.0, it is now looking for repo-root/build instead of repo-root/frontend/build.

Not sure if this was the change that broke it, but looking at the changes it looked like the most likely culprit.

[ehmicky]

Hi @JamesMcMahon,

Could you please print (except for confidential values):

• Your logs when running the Netlify CLI (with the proper current directory), with the environment variable NETLIFY_BUILD_DEBUG set to true
• The output of netlify --version and ./node_modules/.bin/netlify-config --version.
• Your full netlify.toml
• Any build settings you might have set in the Netlify app UI

Thanks!

[FinnWoelm]

@JamesMcMahon, I ran into the same issue. I solved it by creating an empty .git directory in my subdirectory. For some reason, that worked.

My files:

+ .git/
+ node_modules/
+ package.json
+ file1.js
+ file2.js
+ subdirectory/
  + .git/    <-- completely empty directory
  + package.json
  + netlify.toml
  + publish/
  + ...

My netlify.toml configuration:

[build]
  publish = "publish"

My subdirectory package.json:

{
  "name": "test",
  "scripts": {
    "deploy": "../node_modules/.bin/netlify deploy"
  }
}

Perhaps it helps someone 😊

[JamesMcMahon]

Just to clarify, I had no problems fixing the issue. I was reporting it hear because it was a breaking change that got bundled into a seem-lying innocuous minor release.

In my case, I fixed it by changing

[build]
publish = "build"

To:

[build]
publish = "frontend/build"

This is maybe the wrong place to report this, also maybe kind of pointless given that release has already happened. I wanted to record the change for posterity sake.

@ehmicky If you still need any of that information let me know.

[ehmicky]

@JamesMcMahon If you could post any of the information listed above, this could fix this problem for other users without them having to modify their netlify.toml nor add a .git directory. Otherwise, I'm glad your problem is solved :)