Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy: Rename --branch to --alias #943

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Deploy: Rename --branch to --alias #943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb4c7e6
Deploy: Rename --branch to --alias
RaeesBhatti Jun 6, 2020
fcd46e5
Formatting
RaeesBhatti Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/commands/deploy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,15 @@ class DeployCommand extends Command {
async run() {
const { flags } = this.parse(DeployCommand)
const { api, site, config } = this.netlify
const alias = flags.alias || flags.branch

if (flags.branch) {
this.warn('--branch flag has been renamed to --alias and will be removed in future versions')
}

const deployToProduction = flags.prod
if (deployToProduction && flags.branch) {
this.error(`--prod and --branch flags cannot be used at the same time`)
if (deployToProduction && alias) {
this.error(`--prod and --alias flags cannot be used at the same time`)
}
await this.authenticate(flags.auth)

Expand All @@ -34,7 +39,7 @@ class DeployCommand extends Command {
open: flags.open,
prod: flags.prod,
json: flags.json,
branch: Boolean(flags.branch),
alias: Boolean(alias),
},
})

Expand Down Expand Up @@ -199,10 +204,10 @@ class DeployCommand extends Command {
configPath: configPath,
fnDir: functionsFolder,
statusCb: flags.json || flags.silent ? () => {} : deployProgressCb(),
draft: !deployToProduction && !flags.branch,
draft: !deployToProduction && !alias,
message: flags.message,
deployTimeout: flags.timeout * 1000 || 1.2e6,
branch: flags.branch,
branch: alias,
})
} catch (e) {
switch (true) {
Expand Down Expand Up @@ -380,9 +385,12 @@ DeployCommand.flags = {
description: 'Deploy to production',
default: false,
}),
alias: flags.string({
description: "Specifies the alias for deployment. Useful for creating predictable deployment URL's",
}),
branch: flags.string({
char: 'b',
description: "Specifies the branch for deployment. Useful for creating specific deployment URL's",
description: 'Serves the same functionality as --alias. Deprecated and will be removed in future versions',
}),
open: flags.boolean({
char: 'o',
Expand Down