Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checks for "command" and "dir" combination #936

Merged
merged 4 commits into from
Jun 19, 2020

Conversation

RaeesBhatti
Copy link
Contributor

@RaeesBhatti RaeesBhatti commented Jun 3, 2020

- Summary
Fixes: #932

- Test plan
Tests added

  • Have command in netlify.toml [dev] section
  • Run netlify dev --dir something

- Description for the changelog

  • Check for command and targetPort options in flags rather than [dev] config when dir flag is set
  • Make sure command is not set from config when dir flag is set

- A picture of a cute animal (not mandatory but encouraged)
🦥

@RaeesBhatti RaeesBhatti added the type: bug code to address defects in shipped code label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

netlify dev --dir not working with dev command configured
2 participants